fix(ci): update .main.commit for non-dev mcore branches - #3213
Merged
Conversation
When bumping on release branches (e.g. r0.4.0 with mcore-core_r0.17.0), the mcore-branch input matches neither "main" nor "dev", so .main.commit was never written. The unit test test_main_commit_matches_submodule then fails because the submodule no longer matches .main.commit. Fix: write .main.commit for all non-dev branches (main + release branches). Signed-off-by: oliver könig <okoenig@nvidia.com>
1 task
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe workflow file's conditional logic for writing Megatron-LM submodule commit hashes has been restructured. The logic now checks if Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ko3n1g
enabled auto-merge (squash)
April 8, 2026 11:15
thomasdhc
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
r0.4.0withmcore-branch=mcore-core_r0.17.0), themcore-branchinput matches neither"main"nor"dev", so.main.commitwas never writtentest_main_commit_matches_submodulethen fails because the bumped submodule commit no longer matches.main.commit.main.commitfor all non-devbranches (covers bothmainand release branches)Before:
After:
Test plan
test_main_commit_matches_submodulepasses on next bump run forr0.4.0Summary by CodeRabbit
Release Notes
Note: This release contains only internal infrastructure improvements with no direct impact on end-user functionality.